Add support for epoch of observation #325#357
Merged
daleroberts merged 1 commit into1.4.0from Apr 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new Epoch of Observation concept, distinct from the existing reference-frame epoch, throughout the data model and binary formats. This means we have:
epoch: Epoch of Reference Frame (mutable by dnareftran).observation_epoch: Timestamp of when the measurement/station was observed. Immutable under reftran.One thing to note is that this means the binary file format needs to change and is not compatible anymore, which is not an issue since the binary format should only be used as an intermediary stage after
dnaimporthas ingested the XML files. The binary file format has been bumped from1.1to1.2and readers fall backobservation_epoch = epochfor legacy files.A new
--observation-epochoption (accepts dd.mm.yyyy, year-only, or literal today) has been added.